-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intercepting sinks to the organization and folder modules #2799
Add intercepting sinks to the organization and folder modules #2799
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…-Intercept-Child-Logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rshokati2 Thanks for sending this PR! It's been on my to-do list for a while.
These changes also make sense for the folder
module. Could you replicate them there as well?
I've left a few more comments below.
Hey @juliocc, thank you for your prompt review and response, I've made the requested adjustments. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rshokati2!
@rshokati2 can you fix the remaining issues? Or if you want I can fix them but I need permissions to modify your PR |
Hey @juliocc, I did not have access to grant you write permissions on the PR but I believe it's been provided by @EmileHofsink, can you please double check? if you can give me some details, I may be able to assist, as far as I can tell the validation rule seems to be breaking when the type=logging and intercept_child is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rshokati2! I think I've addressed all the issues and it should get merged once all the tests run
Allow fabric organization module to intercept audit logging including all child resources. The validation block ensures both intercept_children and include_children as set to true, and the destination 'type' is a 'project'.
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py