-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SecOps anonymization pipeline #2794
base: master
Are you sure you want to change the base?
Conversation
14f3ded
to
8e6795c
Compare
BUCKET = SECOPS_OUTPUT_BUCKET if not SKIP_ANONYMIZATION else SECOPS_EXPORT_BUCKET | ||
bucket = storage_client.bucket(BUCKET) | ||
export_ids = utils.get_secops_export_folders_for_date(BUCKET, export_date) | ||
backstory_credentials = service_account.Credentials.from_service_account_file( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to do SA impersonation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great but that is a "google managed" SA shared with the customer so the customer cannot update IAM bindings on that SA on his own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P4SA? Well, that sucks...
399ffa3
to
ce431a6
Compare
ce431a6
to
44bb380
Compare
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py