Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SecOps anonymization pipeline #2794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simonebruzzechesse
Copy link
Collaborator

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

BUCKET = SECOPS_OUTPUT_BUCKET if not SKIP_ANONYMIZATION else SECOPS_EXPORT_BUCKET
bucket = storage_client.bucket(BUCKET)
export_ids = utils.get_secops_export_folders_for_date(BUCKET, export_date)
backstory_credentials = service_account.Credentials.from_service_account_file(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to do SA impersonation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great but that is a "google managed" SA shared with the customer so the customer cannot update IAM bindings on that SA on his own

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4SA? Well, that sucks...

@simonebruzzechesse simonebruzzechesse force-pushed the bruzz/secops-anonymization branch 2 times, most recently from 399ffa3 to ce431a6 Compare January 8, 2025 08:20
@simonebruzzechesse simonebruzzechesse force-pushed the bruzz/secops-anonymization branch from ce431a6 to 44bb380 Compare January 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants