-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MQTT auto-reconnect with custom topic issues + update mqtt #2197
Fix MQTT auto-reconnect with custom topic issues + update mqtt #2197
Conversation
The code changes fix the MQTT reconnect logic in the connect.js file. It now checks if the reconnecting flag is set before disconnecting. If the flag is not set, it sets the flag to true, logs a warning message, and attempts to reconnect to the MQTT server after a 500ms delay. Once the reconnection is complete, the flag is set back to false. If the flag is already set, it simply disconnects from the MQTT server. Additionally, the index.js file now initializes the reconnecting flag to false.
#2938 Bundle Size — 10.41MiB (0%).c87479f(current) vs d6461e0 master#2935(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2938 |
Baseline #2935 |
|
---|---|---|
Initial JS | 5.64MiB |
5.64MiB |
Initial CSS | 304.89KiB |
304.89KiB |
Cache Invalidation | 0% |
54.06% |
Chunks | 51 |
51 |
Assets | 173 |
173 |
Modules | 1511 |
1511 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.83% |
0.83% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type no changes
Current #2938 |
Baseline #2935 |
|
---|---|---|
JS | 7.43MiB |
7.43MiB |
IMG | 2.54MiB |
2.54MiB |
CSS | 321.79KiB |
321.79KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.79KiB |
17.79KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch Terdious:fix/mqtt-broker-reconne... Project dashboard
Generated by RelativeCI Documentation Report issue
Remove unused reconnecting flag in MqttHandler Fix listenToCustomMqttTopicIfNeeded to only subscribe if mqttTopic is provided Remove reconnect logic in connect.js
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2197 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 876 876
Lines 14432 14432
=======================================
Hits 14221 14221
Misses 211 211 ☔ View full report in Codecov by Sentry. |
The code changes fix the MQTT reconnect logic in the connect.js file. It now checks if the reconnecting flag is set before disconnecting. If the flag is not set, it sets the flag to true, logs a warning message, and attempts to reconnect to the MQTT server after a 500ms delay. Once the reconnection is complete, the flag is set back to false. If the flag is already set, it simply disconnects from the MQTT server. Additionally, the index.js file now initializes the reconnecting flag to false.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Fixed mqtt service auto-reconnect issue which was caused by mishandled custom topic issues