-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cast integration #2088
Merged
Merged
Google Cast integration #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying gladys-plus with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
=======================================
Coverage 98.40% 98.41%
=======================================
Files 858 865 +7
Lines 14081 14162 +81
=======================================
+ Hits 13857 13938 +81
Misses 224 224 ☔ View full report in Codecov by Sentry. |
#2597 Bundle Size — 10.18MiB (+0.41%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2597 |
Baseline #2576 |
|
---|---|---|
Initial JS | 5.48MiB (+0.53% ) |
5.46MiB |
Initial CSS | 303.12KiB (+0.05% ) |
302.96KiB |
Cache Invalidation | 57.36% |
63.14% |
Chunks | 51 |
51 |
Assets | 171 (+0.59% ) |
170 |
Modules | 1490 (+0.68% ) |
1480 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.82% |
0.82% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 4 changes
4 regressions
Current #2597 |
Baseline #2576 |
|
---|---|---|
JS | 7.27MiB (+0.4% ) |
7.24MiB |
IMG | 2.48MiB (+0.5% ) |
2.46MiB |
CSS | 319.91KiB (+0.05% ) |
319.75KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.62KiB (+0.51% ) |
17.53KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch google-cast-integration Project dashboard
…Gladys into google-cast-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.Description of change
Add support for Nest Mini speakers