-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zigbee2mqtt): Add z2m ui link in Setup page #1903
feat(zigbee2mqtt): Add z2m ui link in Setup page #1903
Conversation
9c70cf4
to
7871ab4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Job #1939: Bundle Size — 8.82MiB (+0.01%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1939 report View cicoub13:feat-zigbee2mqtt-doc branch activity |
What will be the URL if I'm not on localhost? Using a raspberry ou a NAS hosting Gladys? Or via Gladys Plus? |
It will be something like http://192.168.1.11:8080 with device IP
Link will not be showned (because not accessible from Internet) |
I just check your code, it will use the "localApiUrl" configuration variable to define de base URL, which means that default "localhost" will be used for most of Gladys user. |
I took code from @callemand about node-red
But let me test it in real world with a docker image 🤔 |
Maybe you should build the entire url from the front side, according to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for my tired eyes ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure the Gladys Plus part is working!
front/src/routes/integration/all/zigbee2mqtt/setup-page/actions.js
Outdated
Show resolved
Hide resolved
7871ab4
to
9b2c66d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 🙏 Good for me !
Fix #1893