Skip to content

Commit

Permalink
Integration form password should not be autocompleted by browser (#1881)
Browse files Browse the repository at this point in the history
  • Loading branch information
Pierre-Gilles authored Sep 15, 2023
1 parent 5a1f873 commit b998ccb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class SetupForm extends Component {
value={props.mqttUsername}
class="form-control"
onInput={this.updateUsername}
autoComplete="no"
autocomplete="off"
disabled={gladysNotAvailable}
/>
</Localizer>
Expand All @@ -93,7 +93,7 @@ class SetupForm extends Component {
value={props.mqttPassword}
class="form-control"
onInput={this.updatePassword}
autoComplete="new-password"
autocomplete="off"
disabled={gladysNotAvailable}
/>
</Localizer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ const NextcloudTalkPage = ({ children, ...props }) => (
<input
type="text"
class="form-control"
autocomplete="off"
placeholder={<Text id={`integration.nextcloudTalk.username`} />}
onInput={props.updateNextcloudBotUsername}
value={props.nextcloudBotUsername}
Expand All @@ -62,6 +63,7 @@ const NextcloudTalkPage = ({ children, ...props }) => (
<Localizer>
<input
type="password"
autocomplete="off"
class="form-control"
placeholder={<Text id={`integration.nextcloudTalk.password`} />}
onInput={props.updateNextcloudBotPassword}
Expand Down
2 changes: 2 additions & 0 deletions front/src/routes/integration/all/tasmota/TasmotaDeviceBox.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ class TasmotaDeviceBox extends Component {
id={`username_${deviceIndex}`}
type="text"
class="form-control"
autocomplete="off"
onInput={this.updateUsername}
placeholder={<Text id="integration.tasmota.discover.http.usernameLabel" />}
/>
Expand All @@ -159,6 +160,7 @@ class TasmotaDeviceBox extends Component {
<Localizer>
<input
id={`password_${deviceIndex}`}
autocomplete="off"
type="password"
class="form-control"
onInput={this.updatePassword}
Expand Down

0 comments on commit b998ccb

Please sign in to comment.