Fix no results showing while there are results (#2719)

GitbookIO · Jan 10, 2025 · 6059efe · 6059efe
1 parent 16194c5
commit 6059efe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/breezy-days-pull.md b/.changeset/breezy-days-pull.md
@@ -0,0 +1,5 @@
+---
+'gitbook': patch
+---
+
+Fix search no results error showing while there are results
diff --git a/packages/gitbook/src/components/Search/SearchResults.tsx b/packages/gitbook/src/components/Search/SearchResults.tsx
@@ -36,7 +36,7 @@ type ResultType =
  * Fetch the results of the keyboard navigable elements to display for a query:
  *   - Recommended questions if no query is provided.
  *   - Search results if a query is provided.
- *      - If withAsk is true and the query is a question, add a question result.
+ *      - If withAsk is true, add a question result.
  */
 export const SearchResults = React.forwardRef(function SearchResults(
     props: {
@@ -299,7 +299,7 @@ export const SearchResults = React.forwardRef(function SearchResults(
                             }
                         })}
                     </div>
-                    {results.filter((result) => result.type === 'question').length > 0 && noResults}
+                    {!results.some((result) => result.type !== 'question') && noResults}
                 </>
             )}
         </div>