-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WofE CLI functions #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my comments below, please add CLI function for agterberg_cheng_CI_test
tool
…culate_responses_cli
@nmaarnio Ready for another review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good now and seems to work. I would only change the output file naming logic, see my comment below
Give output arrays more descriptive/identifying file names
This PR adds CLI functions for the two WofE functions.
In the first CLI function (
weights_of_evidence_calculate_weights_cli
), the resulting dataframe is saved into a CSV file and the arrays are saved as rasters. The number of deposit pixels and evidence pixels are only printed to the user.In the second CLI function (
weights_of_evidence_calculate_responses_cli
), the resulting probability and confidence arrays are saved as rasters.In the latter CLI function, there are at least two options how to transform the input rasters into an array of dictionaries needed in the corresponding toolkit function:
weights_of_evidence_calculate_weights_cli
are in separate folders. As many dictionaries will be created as there are distinct (innermost) folders in the paths of the input rasters. I'm not sure whether this approach will work with the plugin.I believe the first approach makes more sense, but I'll let you comment which approach you prefer @nmaarnio.