Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle boolean values for val keyword correctly #118

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

hhaensel
Copy link
Member

@hhaensel hhaensel commented Nov 7, 2023

This PR fixes #57 by allowing supply of Bool values,

julia> radio("Bar plot", :show_bar, val = true)
"<q-radio :val=\"true\" label=\"Bar plot\" v-model=\"show_bar\"></q-radio>"

With this solution you are still allowed to write

julia> radio("Bar plot", :show_bar, val = "true")
"<q-radio val=\"true\" label=\"Bar plot\" v-model=\"show_bar\"></q-radio>"

which will attach the string "true"

@hhaensel hhaensel merged commit 0d4073d into master Nov 9, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radiobutton does not update reactive field for val = "false"
1 participant