Allow Notify.gov to use more languages (notify-admin #867) #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrazoon
changed the title
|
It's good in the long run that poetry is going to enforce compatibility between dependencies in utils, admin, and api. But in the short run, the projects are currently not compatible. After resolving things so they can run together locally, I'm still getting unit test failures from some unhappy dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the move to poetry in notifications_utils has the side (desired, probably) effect that the api and admin project will now check their compatibility with notification_utils dependencies and reject it if there is an issue. I ran in to several incompatibilities and have fixed as best I could in this PR and in my PRs for api and admin.
Additionally, it looks like daily_total_cache_key was removed from the utils project but not from the api or admin projects. I have put temporary workarounds in the api and admin PRs. But as of right now, if you pull down the api and admin PRs and run them, you can see that it is possible to send text messages for our new supported languages.