Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Security Content #2127

Merged
merged 5 commits into from
Nov 26, 2024
Merged

About Security Content #2127

merged 5 commits into from
Nov 26, 2024

Conversation

heyitsmebev
Copy link
Contributor

@heyitsmebev heyitsmebev commented Nov 18, 2024

As part of the new About Notify content section, this PR is the implementation for "Security"
image

Definition of Done

  • Should include a side navigation
  • Should be able to easily navigate to About Notify content
  • Should meet a11y standards

Figma:
https://www.figma.com/proto/aAWhlPzOP6kfVFnCCAfSZZ/notify.gov?page-id=2339%3A3817&node-id=5392-875&node-type=frame&viewport=2870%2C-701%2C0.48&t=nfkxOXnOCIFQB1yK-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=5392%3A875

Content:
https://docs.google.com/document/d/1lP8I0Jxu0B26cmTGBQcoHCbfSvKKHQBE6gzTL9HUheE/edit?tab=t.0#heading=h.icyigvoln8tg

@heyitsmebev heyitsmebev linked an issue Nov 18, 2024 that may be closed by this pull request
@heyitsmebev heyitsmebev self-assigned this Nov 18, 2024
@jonathanbobel
Copy link
Contributor

jonathanbobel commented Nov 20, 2024

@heyitsmebev all links that leave the Notify.gov site need an external link icon added
https://designsystem.digital.gov/components/link/

Example:

 <a
    class="usa-link usa-link--external"
    rel="noreferrer"
    target="_blank"
    href="https://i.giphy.com/media/WPzQF6ruiIIVzHNlwX/source.gif"
    >external website</a
  >.

@dmvancura
Copy link

Security is a subpage to the About Notify section. It is navigated to after a user selects to view the About Notify section. @CathyBeil and @jonathanbobel, correct, yes? Note: It is in front of the login, but i understand that's a different PR.

@heyitsmebev
Copy link
Contributor Author

heyitsmebev commented Nov 21, 2024

@dmvancura i revised the menu hierarchy in this PR. Security is indeed a subnav

Copy link
Contributor

@jonathanbobel jonathanbobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmvancura
Copy link

anything else needed on 2127? github is a bit confusing and i can't tell by looking through this, so let me know if i need to help with anything else @jonathanbobel

@heyitsmebev heyitsmebev merged commit 9abfcf7 into main Nov 26, 2024
11 checks passed
@heyitsmebev heyitsmebev deleted the 2103-aboutsecurity branch November 26, 2024 00:51
@heyitsmebev heyitsmebev linked an issue Dec 4, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About/Security Build out the About section - templates and side nav
4 participants