Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment network policy resource #1779

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Uncomment network policy resource #1779

merged 3 commits into from
Jul 29, 2024

Conversation

jskinne3
Copy link
Contributor

@jskinne3 jskinne3 commented Jul 26, 2024

  • Uncomment a resource providing Container-to-Container Networking, allowing Sandbox Admin and API to talk
  • Remove boilerplate code comments left over from the early days

This PR is a pair with GSA/notifications-api#1217
A part of issue GSA/notifications-api#883

@jskinne3 jskinne3 changed the title Jskinne3 network policy Uncomment network policy resource Jul 26, 2024
Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

null_resource.prevent_destroy: Refreshing state... [id=1728082765789994772]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=d67c8c05-f22b-4fca-ba0b-312af08a61eb]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=13ac7990-e80e-4c07-8208-f6736a87c1d2]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=5d983d08-5079-4159-8721-67edf948d345]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=89c9b6a9-f030-4752-b30f-6b3193a25148]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=45c461a7-cc6c-c60d-cea7-1f5480589b64]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Pusher: @jskinne3, Action: pull_request

Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jskinne3!

@ccostino ccostino merged commit 84657a6 into main Jul 29, 2024
12 checks passed
@ccostino ccostino deleted the jskinne3-network-policy branch July 29, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants