-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add debug for investigating stack trace in logs #1606
Conversation
Thanks, @terrazoon! This just needs a quick update against |
Terraform Format and Style: success Show Plan
Pusher: @terrazoon, Action: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@terrazoon this just needs a quick sync with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @terrazoon!
Description
There is a stack trace happening, mostly down in the middleware, where an 'invalid IPv6 url' occurs, gets converted to a 500 error, but at the same time causes an exception down in werkzeug when it tries to log, because the RequestContext apparently doesn't have a 'service' attribute.
Wrap our method where the exception seems to occur in a try/except. This may be sufficient and all we can do for this issue (get the stack trace out of the log), but add some debug statements so we can have a better idea of what is actually going on. Like ... what is the original url we are trying to convert? Is it a IPv6 url? Who is using that and why, etc?
Security Considerations
N/A