-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add folding based on fold expression #17
Open
cnrrobertson
wants to merge
3
commits into
GCBallesteros:main
Choose a base branch
from
cnrrobertson:cell_folding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to overwrite whatever code folding a user has set. If you are only on folding cells that is fine but for example one thing that I do quite often after opening a file is zC to close all the folds to get a higher level view.
I would imagine that one approach to fix solve this is to wrap around the folding method currently in use so that it returns the fold level on top of the one that was set before.
Another issue is that this will changed the global fold method. Ideally one would rather use
setlocal
to only change it on the window displaying the buffer of interest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good point about
setlocal
. I've implemented that change.On wrapping the current folding method. I think it could be done if the folding was set to
fold-indent
,fold-expr
, orfold-marker
but I'm not sure how to get anexpr
wrappingfold-syntax
orfold-diff
. Any ideas?In any case, I've also added a warning for the time being that the code folding will replace previously defined
foldmethods
on buffers with valid cell markers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be happy with just having the cell folding working for a limited number of user set folding methods. Indent, expr and marker would be enough as they cover most of the situations.
Currently I'm wokring on wrapping around the output of the current foldexpr such that it produces the correct folding when cells are considered too. I will upload a branch later today or tomorrow morning sketching the idea.