Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider units #116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Slider units #116

wants to merge 4 commits into from

Conversation

timmaffett
Copy link

This PR allows for 2 options to the SliderSettingsTile.
It allows simply adding a units string that is appended to the value,
and also adds a additional option of using a subtitleFormatterCallback for complete control of how the value is formatted and presented to the user.

GAM3RG33K
GAM3RG33K previously approved these changes Sep 11, 2024
Copy link
Owner

@GAM3RG33K GAM3RG33K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GAM3RG33K
Copy link
Owner

@timmaffett There seems to be some conflict of the formatter code, Can you please take the latest pull & update the PR?

Thanks alot for this contribution 😄

@timmaffett
Copy link
Author

timmaffett commented Sep 12, 2024

OK - It should be merged and resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants