notification bugfix and colors parameter #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ToH2002 Hi, I tried to review the changes but the code submitted in PR is poorly formatted, can you please take a minute & check the formatting issue & re-submit? Also, Take a latest pull before updating the PR as there seems to be some conflicts visible in the PR. Thanks. 😄 |
|
I'll work with the latest version and create a pull request once done Cheers Torsten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I created a branch in order to fix a notification bug: notifications didn't affect tiles with a key that contained upper-case letters due to a "ToLower" in the function that lists the tiles to be notified. Since I generally use camelCase to name keys, this created issues.
Also, I added a parameter "colors" to ColorPickerSettingsTile, so users can choose their own color selection.
All other changes are just automatic formatting made by VSCode - sorry about that...
Hope you can incorporate this!