feat: use total_gas
and total_fee
from tx status
#1574
+111
−161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1394
Release notes
In this release, we:
total_gas
andtotal_fee
used for transactions.Summary
The
total_fee
andtotal_gas
is taken from the tx status.The
GasValidation
trait is removed. This trait was used to make sure that thescript_gas_limit
is set correctly. Thescript_gas_limit
is either:0
if there is no script code,so an additional check before sending the tx is redundant - By removing it we have one less dry run before sending the tx.
Breaking Changes
get_response_from
method fromCallHandlers
get_response
acceptsTxStatu
instead ofVec<Receipts>
CallResponse
has new fieldtotal_fee
new
is removed formCallResponse
GasValidation
trait is removed from transaction buildersChecklist