Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rank images #117

Merged
merged 5 commits into from
Dec 12, 2023
Merged

fix: rank images #117

merged 5 commits into from
Dec 12, 2023

Conversation

imorland
Copy link
Member

@imorland imorland commented Dec 12, 2023 •
edited
Loading

Fixes the following:

  • Uploading rank place images in settings failed to display the resulting upload on subfolder installations
  • Impossible to upload rank images when the flarum-assets disk is relocated to another driver (ie S3)
  • Uploaded rank images were not displayed on the rank page
  • Uploaded image aspect ratio was not respected

@imorland imorland merged commit ac31df9 into master Dec 12, 2023
32 checks passed
@imorland imorland deleted the im/rank-image branch December 12, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imorland @StyleCIBot