-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imx-boot and u-boot-imx generation/instalation for when UBOOT_CONFIG is empty #1707
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @angolini, I happened to be looking at taking the
UBOOT_CONFIG
changes into our local layer, but I'm confused how it even works. Since this function can be called multiple times, it will fail on the second call for any files which are notUBOOT_CONFIG
specific (like the ATF file here) since in that case it will be copying the same file to the same location.I feel there is a structural problem with
do_deploy
as well since it callsdeploy_${SOC_FAMILY}
without setting the_EXTRA
variables at all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we have to think of a better way to reorg this recipe. It's becoming more and more disorganized and crazy. But maybe it would be better if we only switch to bootloader container instead?
If you have any suggestions on how to fix/enhance the PR, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe moving to the bootloader container would be better, but in the meantime, I guess the recipe should at least be fixed.
A refactoring of the functions is needed so common logic occurs once and uboot-config-specific logic occurs once per config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed where the spl is copied.
@thochstein , if you know a better way to test this (without the machines, as I don't have them) please, let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just put two values in
UBOOT_CONFIG
? I'm pretty sure that will just fail to build.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing this as well.
But if you think in anything else, please, let me know
(this PR does not touch the multiple UBOOT_CONFIG, it only deals when UBOOT_CONFIG is empty)