Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make depmap annotation optional #65

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Make depmap annotation optional #65

merged 3 commits into from
Nov 18, 2024

Conversation

cansavvy
Copy link
Collaborator

Description

I've turned the cn_annotate argument into depmap_annotate which makes all of the annotation optional. Its mainly just used for plots. So we don't want people to have to use it if they are using a cell line for example that is not included in DepMap.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Need to see if this works in unit testing.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cansavvy cansavvy merged commit dfd8cb1 into main Nov 18, 2024
3 of 6 checks passed
@cansavvy cansavvy deleted the cansavvy/separate-depmap branch November 18, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants