Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log fold change #26

Merged
merged 22 commits into from
Jul 16, 2024
Merged

Log fold change #26

merged 22 commits into from
Jul 16, 2024

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Apr 22, 2024

Description

This step has now been split into two main functions! gimap_normalize() and calc_crispr() are the new stuff here.

Here is how I test this overall:

 gimap_dataset <- get_example_data("gimap") %>%
   gimap_filter() %>%
   gimap_annotate() %>%
   gimap_normalize(
     timepoints = "day",
     replicates = "rep")

Instructions for Reviewers

I have a series of TODOs in the code that ask questions -- either the Berger Lab can help us answer or @kweav if you have insights that's great too. Besides just carefully scrutinizing this and seeing if it more or less is giving the same story as the original code.

A big piece here is that it will need to be re-run once we have filtering steps ready.

@cansavvy cansavvy changed the base branch from main to cansavvy/annotation-schema May 22, 2024 17:22
Base automatically changed from cansavvy/annotation-schema to main June 21, 2024 13:37
@cansavvy cansavvy marked this pull request as ready for review July 3, 2024 18:02
@cansavvy cansavvy requested a review from kweav July 3, 2024 19:06
@cansavvy cansavvy merged commit 73c9acd into main Jul 16, 2024
6 of 7 checks passed
@cansavvy cansavvy deleted the cansavvy/lfc branch July 16, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants