fix: Issue #26 and #55 and add missing fields in type definition + quorum support #56

MartianH · 2024-03-19T10:15:06Z

Fix issue Correct protocol is 'amqp', not 'amqp://' #26 : The accepted protocol value is now amqp and amqps without ://
Fix issue Error when adding a forward slash to PLAIN credentials, throws "TypeError: Invalid URL" #55: Use encodeURIComponent() for both user and password and do not url encode entire string
Add messageTTL and passive to QueueOptiondefinition: documentation states these are valid yet they are not present
Add type to QueueOptions: Sets argument x-queue-type, as to enable quorum support
Adjusted specs: added protocol in connection config (spec/integration/configuration.js) and queue type

…type` (x-queue-type, for quorum support) + protocol definition for Foo-Foo-MQ#26

…error (Foo-Foo-MQ#55)

…d queue type field

… is documented and shown in examples)

…t incompatible fields

… call is valid

…ove readability

…t set)

…recation warning

…s compatible (Foo-Foo-MQ#26)

…ng async/await example with explanation

…once since v3.10 for quorum) + update typing to reflect it

…validate it is correct (only for quorum)

…ue` parameter description + explanation of choices

… fit norm

…le to `const`

…imilar test case for default options.type "classic"

…r test and doc entry

zlintz

Overall looks good just a couple comments. Things that could be good either par

package.json

src/amqp/connection.js

…d double escaping

Martial Habimana added 13 commits March 19, 2024 10:51

chore(package.json): bump version

a16ba0f

feat(index.d.ts): Add messageTtl, passive (existing fields) and `…

5d4fa7c

…type` (x-queue-type, for quorum support) + protocol definition for Foo-Foo-MQ#26

chore(docs): update docs t reflect changes

93ff774

fix(integration): proper protocol (Foo-Foo-MQ#26) and fix url encode …

a7c7120

…error (Foo-Foo-MQ#55)

chore(spec): update connection and queue options with new protocol an…

d7148f2

…d queue type field

refactor(connection.js): use startsWith instead of equal, just in case

3433a50

feat(index.d.ts): Add autoDelete key to QueueOptions definition (it…

b4b2bc7

… is documented and shown in examples)

feat(queue.js): Add proper support for quorum queues and silently omi…

e27cd3e

…t incompatible fields

feat(queue.spec.js): Add test case for quorum queue type and check if…

d4d2c78

… call is valid

refactor(queue.js): Use ternary operation instead for omition to impr…

13ef889

…ove readability

feat(queue.spec.js): Add behavior test case for quorum queue type (no…

2b99f03

…t set)

chore(topology.md): update docs with queue type and classic queue dep…

4e96220

…recation warning

feat(connection.js): make sure protocol field is found and backward…

91164d8

…s compatible (Foo-Foo-MQ#26)

MartianH changed the title ~~Fix issue #26 and #55 and add missing fields in type definition~~ Fix issue #26 and #55 and add missing fields in type definition + quorum support Mar 19, 2024

Martial Habimana added 12 commits March 20, 2024 08:55

docs(topology.md): Added known workaround for issue Foo-Foo-MQ#23 usi…

6258e8d

…ng async/await example with explanation

feat(queue.js): add dead letter strategy argument (supports at least …

9400d03

…once since v3.10 for quorum) + update typing to reflect it

test(queue.spec.js): Check behavior for x-dead-letter-strategy and …

94f56fa

…validate it is correct (only for quorum)

docs(topology.md): Add deadLetterStrategy and overflow to `addQue…

288c855

…ue` parameter description + explanation of choices

docs(topology.md): refactor example and formatting recent addition to…

94b251c

… fit norm

docs(topology.md): shorten example

326ada1

docs(topology.md): update configure example to properly use promises

dc97ca3

docs: finalized toplogy example and changes all outdated var variab…

5b68501

…le to `const`

refactor(connection.js): Avoid duplicate error messages, use constant

0770db6

test(queue.spec.js): Fix value for x-dead-letter-strategy and add s…

33d1f69

…imilar test case for default options.type "classic"

feat(queue.js): Add queue version upport for classic queues + behavio…

a176116

…r test and doc entry

fix: autodelete queue in test has to be classic

feef51e

zlintz previously approved these changes Apr 7, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/amqp/connection.js Show resolved Hide resolved

src/amqp/connection.js Show resolved Hide resolved

chore: revert change a16ba0f (bump version)

85b7081

MartianH dismissed zlintz’s stale review via 85b7081 April 8, 2024 14:24

MartianH requested a review from zlintz April 8, 2024 14:26

fix(amqp/connection.js): decode URI credentials in parseUri to avoi…

a84d619

…d double escaping

zlintz approved these changes Apr 9, 2024

View reviewed changes

zlintz merged commit e503616 into Foo-Foo-MQ:main Apr 9, 2024
2 checks passed

MartianH changed the title ~~Fix issue #26 and #55 and add missing fields in type definition + quorum support~~ fix: Issue #26 and #55 and add missing fields in type definition + quorum support Apr 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Issue #26 and #55 and add missing fields in type definition + quorum support #56

fix: Issue #26 and #55 and add missing fields in type definition + quorum support #56

MartianH commented Mar 19, 2024 •

edited

Loading

zlintz left a comment

fix: Issue #26 and #55 and add missing fields in type definition + quorum support #56

fix: Issue #26 and #55 and add missing fields in type definition + quorum support #56

Conversation

MartianH commented Mar 19, 2024 • edited Loading

zlintz left a comment

Choose a reason for hiding this comment

MartianH commented Mar 19, 2024 •

edited

Loading