Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vee4 patch 1 #2560

Closed
wants to merge 6 commits into from
Closed

Conversation

VforViolin
Copy link
Contributor

@VforViolin VforViolin commented Jun 8, 2024

Fixed so the effect does not trigger if it changes control before the chain in which the trigger effect would meet its activation conditions.

Fixed so the effect does not trigger if it changes control before the chain in which the trigger effect would meet its activation conditions.
Fixed so the effect does not trigger if it changes control before the chain in which the trigger effect would meet its activation conditions.
Fixed so the effect does not trigger if it changes control before the chain in which the trigger effect would meet its activation conditions.
Fixed so the effect does not trigger if it changes control before the chain in which the trigger effect would meet its activation conditions.
@mercury233
Copy link
Collaborator

any ruling?

@VforViolin
Copy link
Contributor Author

@VforViolin
Copy link
Contributor Author

This should also apply to most trigger effects that rely on an action being taken by a player, but control is shifted before the chain where the trigger would be met solves.

@salix5
Copy link
Collaborator

salix5 commented Jul 18, 2024

https://ocg-rule.readthedocs.io/zh-cn/latest/c03/%E8%AF%B1%E5%8F%91%E7%B1%BB%E6%95%88%E6%9E%9C.html#id28

假面英雄 暗爪」等,在发动条件中记述了『自己』『对方』的效果,在连锁处理中满足发动条件,之后控制权转移的场合,另1个玩家并不满足发动条件,结果不能发动。

https://www.db.yugioh-card.com/yugiohdb/faq_search.action?ope=5&fid=21045&request_locale=ja
https://www.db.yugioh-card.com/yugiohdb/faq_search.action?ope=5&fid=23484&request_locale=ja

@VforViolin
Copy link
Contributor Author

Yes, both rulings support this commit. This also applies to Imsety, Duamutef, Quebesenuef, and Hapi, along with several other cards too, though for the Horus monsters I had to use
SetCode(EVENT_CUSTOM+id)
and
aux.RegisterMergedDelayedEvent(c,id,EVENT_LEAVE_FIELD)
to get the same result

@salix5
Copy link
Collaborator

salix5 commented Jul 18, 2024

confirming
related PR: #2480

@salix5
Copy link
Collaborator

salix5 commented Jul 18, 2024

2a6ce77

Test replay:

--[[message bug_test]]
Debug.SetAIName("Test")
Debug.ReloadFieldBegin(DUEL_ATTACK_FIRST_TURN+DUEL_SIMPLE_AI)
Debug.SetPlayerInfo(0,8000,0,0)
Debug.SetPlayerInfo(1,8000,0,0)

Debug.AddCard(32909498,0,0,LOCATION_HAND,0,POS_FACEDOWN)
Debug.AddCard(72270339,0,0,LOCATION_HAND,1,POS_FACEDOWN)

Debug.AddCard(98777036,0,0,LOCATION_MZONE,0,POS_FACEUP_ATTACK)
Debug.AddCard(97077563,0,0,LOCATION_SZONE,0,POS_FACEDOWN)
Debug.AddCard(98045062,0,0,LOCATION_SZONE,1,POS_FACEDOWN)

Debug.AddCard(66570171,0,0,LOCATION_DECK,0,POS_FACEDOWN)
Debug.AddCard(40044918,0,0,LOCATION_DECK,1,POS_FACEDOWN)
Debug.AddCard(66570171,0,0,LOCATION_DECK,2,POS_FACEDOWN)
Debug.AddCard(32909498,0,0,LOCATION_GRAVE,0,POS_FACEUP_ATTACK)

Debug.AddCard(32909498,1,1,LOCATION_MZONE,0,POS_FACEUP_ATTACK)
Debug.AddCard(9634146,1,1,LOCATION_MZONE,1,POS_FACEUP_ATTACK)

Debug.ReloadFieldEnd()

EVENT_CHAINING+EFFECT_FLAG_DELAY
It means that Kashtira Fenrir must be on the filed when the monster effect is activated.
If the code is changed into EVENT_CHAIN_SOLVED, it will not work.

@VforViolin
Copy link
Contributor Author

Well, Ive already got the script with it changed to "EVENT_CHAIN_SOLVED" set up for both Dueling Nexus and YGO Omega, and it works fine without any issues, and doesnt allow the trigger effect to activate if Fenrir changes control before the end of the chain.

@salix5
Copy link
Collaborator

salix5 commented Jul 18, 2024

Did you test

Field of A: Monster X
Field of B: Call of the Haunted
GY of B: Fenrir

CL1: A, X
CL2: B, Call of the Haunted (target: Fenrir)

Test:
The single play above
ocgcore@master

in branch VforViolin-Vee4-Patch-1
B can activate the effect of Fennir.
But he shouldn't.

I think it does not work.

@VforViolin
Copy link
Contributor Author

I'll have to test it later today.

@VforViolin
Copy link
Contributor Author

Ive confirmed that the situation you listed above does allow Fenrir to trigger

@salix5
Copy link
Collaborator

salix5 commented Jul 20, 2024

Thank you.

@salix5 salix5 closed this Jul 27, 2024
Lyris12 added a commit to Lyris12/ygopro-scripts that referenced this pull request Jul 27, 2024
`Kashtira Fenrir`
`Kashtira Unicorn`
`Kashtira Ogre`

continued from Fluorohydride#2560
@Lyris12
Copy link
Contributor

Lyris12 commented Jul 27, 2024

fixed at #2609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants