Merge pull request #72 from FigureTechnologies/jd/checksum-display

Fix Checksum Failed Message to Show the Mismatched Sums
FigureTechnologies · May 9, 2024 · 107e48a · 107e48a
2 parents 5f57604 + 13c3121
commit 107e48a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/bech32/src/main/kotlin/tech/figure/hdwallet/bech32/Bech32.kt b/bech32/src/main/kotlin/tech/figure/hdwallet/bech32/Bech32.kt
@@ -44,10 +44,11 @@ object Bech32 {
         }
 
         val dataBytes = dataString.map { c -> charset.indexOf(c).toByte() }.toByteArray()
-        val checkBytes = dataString.takeLast(CHECKSUM_SIZE).map { c -> charset.indexOf(c).toByte() }.toByteArray()
         val actualSum = checksum(hrp, dataBytes.dropLast(CHECKSUM_SIZE).toByteArray())
         require(1 == polymod(expandHrp(hrp).plus(dataBytes.map { d -> d.toInt() }))) {
-            "checksum failed: $checkBytes != $actualSum"
+            val providedCheckSum =  dataString.takeLast(CHECKSUM_SIZE)
+            val actualSumBech32Data = actualSum.map { charset[it.toInt()] }.joinToString("")
+            "checksum failed: got $providedCheckSum but expected $actualSumBech32Data"
         }
 
         return Bech32Data(hrp, dataBytes.dropLast(CHECKSUM_SIZE).toByteArray())