Fixing exchange handling (#178)

FastyBird · Nov 20, 2023 · 9cc47d1 · 9cc47d1
1 parent ba5c11e
commit 9cc47d1
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/src/Writers/Event.php b/src/Writers/Event.php
@@ -85,6 +85,7 @@ public static function getSubscribedEvents(): array
 	}
 
 	/**
+	 * @throws DevicesExceptions\InvalidArgument
 	 * @throws DevicesExceptions\InvalidState
 	 * @throws MetadataExceptions\InvalidArgument
 	 * @throws MetadataExceptions\InvalidState
@@ -145,6 +146,7 @@ public function stateChanged(
 	}
 
 	/**
+	 * @throws DevicesExceptions\InvalidArgument
 	 * @throws DevicesExceptions\InvalidState
 	 * @throws MetadataExceptions\InvalidArgument
 	 * @throws MetadataExceptions\InvalidState

diff --git a/src/Writers/Exchange.php b/src/Writers/Exchange.php
@@ -25,6 +25,7 @@
 use FastyBird\DateTimeFactory;
 use FastyBird\Library\Bootstrap\Helpers as BootstrapHelpers;
 use FastyBird\Library\Exchange\Consumers as ExchangeConsumers;
+use FastyBird\Library\Exchange\Exceptions as ExchangeExceptions;
 use FastyBird\Library\Metadata\Documents as MetadataDocuments;
 use FastyBird\Library\Metadata\Exceptions as MetadataExceptions;
 use FastyBird\Library\Metadata\Types as MetadataTypes;
@@ -54,6 +55,8 @@ class Exchange extends Periodic implements Writer, ExchangeConsumers\Consumer
 	 * @param DevicesModels\Configuration\Devices\Repository<MetadataDocuments\DevicesModule\Device> $devicesConfigurationRepository
 	 * @param DevicesModels\Configuration\Channels\Repository<MetadataDocuments\DevicesModule\Channel> $channelsConfigurationRepository
 	 * @param DevicesModels\Configuration\Channels\Properties\Repository<MetadataDocuments\DevicesModule\ChannelDynamicProperty|MetadataDocuments\DevicesModule\ChannelVariableProperty|MetadataDocuments\DevicesModule\ChannelMappedProperty> $channelsPropertiesConfigurationRepository
+	 *
+	 * @throws ExchangeExceptions\InvalidArgument
 	 */
 	public function __construct(
 		MetadataDocuments\DevicesModule\Connector $connector,
@@ -81,15 +84,26 @@ public function __construct(
 			$dateTimeFactory,
 			$eventLoop,
 		);
+
+		$this->consumer->register($this, null, false);
 	}
 
+	/**
+	 * @throws DevicesExceptions\InvalidState
+	 * @throws ExchangeExceptions\InvalidArgument
+	 * @throws MetadataExceptions\InvalidArgument
+	 * @throws MetadataExceptions\InvalidState
+	 */
 	public function connect(): void
 	{
 		parent::connect();
 
 		$this->consumer->enable(self::class);
 	}
 
+	/**
+	 * @throws ExchangeExceptions\InvalidArgument
+	 */
 	public function disconnect(): void
 	{
 		parent::disconnect();

diff --git a/src/Writers/Periodic.php b/src/Writers/Periodic.php
@@ -46,7 +46,7 @@ abstract class Periodic
 
 	private const HANDLER_START_DELAY = 5.0;
 
-	private const HANDLER_DEBOUNCE_INTERVAL = 5_000.0;
+	private const HANDLER_DEBOUNCE_INTERVAL = 2_500.0;
 
 	private const HANDLER_PROCESSING_INTERVAL = 0.01;
 
@@ -114,6 +114,7 @@ public function disconnect(): void
 	}
 
 	/**
+	 * @throws DevicesExceptions\InvalidArgument
 	 * @throws DevicesExceptions\InvalidState
 	 * @throws MetadataExceptions\InvalidArgument
 	 * @throws MetadataExceptions\InvalidState
@@ -145,6 +146,7 @@ private function handleCommunication(): void
 	}
 
 	/**
+	 * @throws DevicesExceptions\InvalidArgument
 	 * @throws DevicesExceptions\InvalidState
 	 * @throws MetadataExceptions\InvalidArgument
 	 * @throws MetadataExceptions\InvalidState