Skip to content

Commit

Permalink
... but need to move tests for #71 back under failing for 3.x due to …
Browse files Browse the repository at this point in the history
…diff in yaml engine
  • Loading branch information
cowtowncoder committed Nov 23, 2020
1 parent b50ad8b commit 69ec7d0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,6 @@ protected JsonToken _decodeScalar(ScalarEvent scalar) throws IOException
final int len = value.length();
if (!typeTagOptional.isPresent() || typeTagOptional.get().equals("!")) { // no, implicit
Tag nodeTag = _yamlResolver.resolve(value, scalar.getImplicit().canOmitTagInPlainScalar());

if (nodeTag == Tag.STR) {
return JsonToken.VALUE_STRING;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.dataformat.yaml.deser;
package com.fasterxml.jackson.dataformat.yaml.failing;

import java.math.BigInteger;

Expand All @@ -7,6 +7,10 @@

// [dataformats-text#71]: hex numbers
// [dataformats-text#233]: also binary, octal (with/without underscores)
//
// 23-Nov-2020, tatu: Alas, snakeyaml_engine does not really support
// detecting these variants (maybe wrt YAML 1.1 -> 1.2 changes).
// So tests fail. Not sure what to do about this.
public class NumberAltIntRead71Test extends ModuleTestBase
{
static class IntHolder {
Expand Down

0 comments on commit 69ec7d0

Please sign in to comment.