Fixed #121 (main fix in jackson-databind)

FasterXML · Jun 30, 2020 · 38a1312 · 38a1312
1 parent e6b176e
commit 38a1312
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/release-notes/VERSION-2.x b/release-notes/VERSION-2.x
@@ -8,6 +8,8 @@ Project: jackson-dataformat-xml
 
 #97: Weird Exception during read with Type info
  (reported by Pascal G)
+#121: `XmlMapper` not deserializing root-level Enums
+ (reported by bhkjersten@github)
 #124: Deserialization if an empty list (with empty XML tag) results in `null`
  (reported by Denis C)
 #205: `XmlMapper`/`UntypedObjectDeserializer` swallows duplicated elements in

diff --git a/...ckson/dataformat/xml/deser/TestEnums.java → ...n/dataformat/xml/deser/EnumDeserTest.java b/...ckson/dataformat/xml/deser/TestEnums.java → ...n/dataformat/xml/deser/EnumDeserTest.java
@@ -2,7 +2,7 @@
 
 import com.fasterxml.jackson.dataformat.xml.*;
 
-public class TestEnums extends XmlTestBase
+public class EnumDeserTest extends XmlTestBase
 {
     static enum TestEnum { A, B, C; }
 
@@ -21,12 +21,21 @@ public EnumBean() { }
      */
 
     private final XmlMapper MAPPER = new XmlMapper();
-    
-    public void testEnum() throws Exception
+
+    public void testEnumInBean() throws Exception
     {
         String xml = MAPPER.writeValueAsString(new EnumBean(TestEnum.B));
         EnumBean result = MAPPER.readValue(xml, EnumBean.class);
         assertNotNull(result);
         assertEquals(TestEnum.B, result.value);
     }
+
+    // [dataformat-xml#121]
+    public void testRootEnum() throws Exception
+    {
+        String xml = MAPPER.writeValueAsString(TestEnum.B);
+        TestEnum result = MAPPER.readValue(xml, TestEnum.class);
+        assertNotNull(result);
+        assertEquals(TestEnum.B, result);
+    }
 }
diff --git a/src/test/java/com/fasterxml/jackson/dataformat/xml/failing/EnumIssue9Test.java b/src/test/java/com/fasterxml/jackson/dataformat/xml/failing/EnumIssue9Test.java
@@ -47,13 +47,4 @@ public void testUntypedEnum() throws Exception
 
         assertEquals(TestEnum.B, result.value);
     }
-
-    // [dataformat-xml#121]
-    public void testRootEnumIssue121() throws Exception
-    {
-        String xml = MAPPER.writeValueAsString(TestEnum.B);
-        TestEnum result = MAPPER.readValue(xml, TestEnum.class);
-        assertNotNull(result);
-        assertEquals(TestEnum.B, result);
-    }
 }