Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in People #139

Closed
wants to merge 4 commits into from
Closed

Merge in People #139

wants to merge 4 commits into from

Conversation

ct-martin
Copy link
Member

The hard work here wasn't done by me, I copied most of the repo in and then changed the templates to use Bootstrap. Also, Font Awesome is now available for icons (unblocks FOSSRIT/people#74, FA will need to be updated though)

Couple notes:

  • the people repo will need to be unpublished from GitHub pages b/c the URLs will collide
  • sorry for not chatting in IRC first; I got bored and wasn't planning to make a full PR of this when I started

Fixes FOSSRIT/people#72

image

cc @jwflory @10eMyrT @kennedy

(and basic cleanup to make load within foss website templates)

Note that this work is essentially not mine and came from https://github.com/FOSSRIT/people
Couple other minor fixes:
* Monospace for usernames
* Capitalization fixes for GitHub & GitLab
* Remove "Built on" text
Tweaked logic slightly
@jwflory
Copy link
Member

jwflory commented Mar 27, 2020

Hey @ct-martin, in the last Tech Team meeting on Sunday, we decided we would not merge the repos together. We want to keep them separate. I didn't get these notes into the GitHub issue yet though. What we are looking for on FOSSRIT/people#72 is a link in the header on the FOSS website that takes you to the /people page, and then a link/header at the top of the /people page that takes you back to the main FOSS website.

I'll take another look at this tomorrow and see if we can make good on some of your work though. Next time please drop a comment in the issue to discuss first.

@jwflory jwflory self-assigned this Mar 27, 2020
@jwflory jwflory added blocked Progress blocked by another task or issue new change Adds new capabilities or functionality labels Mar 27, 2020
@jwflory
Copy link
Member

jwflory commented Apr 9, 2020

To follow up on the last comment, we are keeping the two repositories separate for now. I know @10eMyrT is backlogged with a few things, but this is on the backburner for now. I appreciate the interest on working on this either way @ct-martin. Thanks 😃

@jwflory jwflory closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress blocked by another task or issue new change Adds new capabilities or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[story] Integrate more closely with FOSS@RIT website
2 participants