Label Constants #4
Conversation
There was a problem hiding this comment.
I'm happy that you were agotid idea of all the units during yesterday's meeting; I can tell that yow the information! Let's work a little more on making everything organized and easily read. I added a few comments, but many of them apply to multiple constants. Take a look at my original labels, as well as some of the examples that I did in the comments of this review, they may help you! Go ahead and request my review again when you feel that you've got more organization going.
|
|
||
| public static final boolean TOP_ROLLER_INVERTED = false; | ||
| public static final boolean BOTTOM_ROLLER_INVERTED = false; | ||
| public static final boolean TOP_ROLLER_INVERTED = false; // Sets the Intake Top Roller to spin forward [True | False] |
|
|
||
| public static final double TOP_ROLLER_REDUCTION = (15.0 / 30.0); | ||
| public static final double BOTTOM_ROLLER_REDUCTION = (1.0 / 2.89); | ||
| public static final double TOP_ROLLER_REDUCTION = (15.0 / 30.0); // The gear reduction for the top rollers [Roller Revolutions / Motor Revolution] |
There was a problem hiding this comment.
Let's stick to Title Case Capitalization
|
|
||
| public static final boolean FRONT_ROLLERS_INVERTED = false; | ||
| public static final boolean BACK_ROLLERS_INVERTED = false; | ||
| public static final boolean FRONT_ROLLERS_INVERTED = false; // Makes the Indexer Front Rollers spin forward/backward [True | False] |
There was a problem hiding this comment.
Does are constant make anything happen?
|
|
||
| public static final double FRONT_ROLLERS_DIAMETER = 2.0; | ||
| public static final double BACK_ROLLERS_DIAMETER = 2.0; | ||
| public static final double FRONT_ROLLERS_DIAMETER = 2.0; // Diameter of Front Rollers [in] |
There was a problem hiding this comment.
Let's call them "Front Indexer Rollers".
I added labels and descriptions to each constant in the code, assigned in #3.