Remove all runtime Javascript dependencies #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
remove-js-deps
branch
from
5c3785e to
e4e1fa0
Compare
matthieusieben
force-pushed
the
remove-js-deps
branch
from
e4e1fa0 to
169e332
Compare
lyrixx
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Thanks!
LGTM, but I prefer a review from @FGRibreau before merging
|
@lyrixx I'm sorry, I currently don't have a lot of free time, can anyone else review this so we're sure we don't have any regressions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependenciesare actuallydevDependenciesnode-rangecan be easily removedZero runtime deps makes this package less susceptible to dependency attacks.