-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update/SOF 7453 #187
Open
VsevolodX
wants to merge
20
commits into
main
Choose a base branch
from
update/SOF-7453
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
update/SOF 7453 #187
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0372340
update: add function to create empty material
VsevolodX c60c674
update: add tests for empty material
VsevolodX 00aee13
update: test to sync cell with lattice
VsevolodX 98c240c
update: test to sync cell with lattice
VsevolodX ac95cf9
update: allow for lattice.vectors.a
VsevolodX 438d572
update: use lattice.vecotrs.a
VsevolodX e2dbbe5
update: fix tests
VsevolodX ba80d7f
update: fix perturbation
VsevolodX 0c02d04
update: remove unused
VsevolodX 32be2c1
update: add tolerance
VsevolodX d975ab7
update: adjust test
VsevolodX d90a534
chore: lint fix
VsevolodX baec628
update: add tolerance to test
VsevolodX bd174a5
update: add coord numbers distribution func
VsevolodX c8f7a07
update: add tolerances to filter funcs
VsevolodX 35ca52a
update: fix erroneous error
VsevolodX c821d1d
chore: lint fix
VsevolodX 34da867
update: tests
VsevolodX 97bc76e
update: simplify create_empty
VsevolodX 9751c79
update: separate lattice tests:
VsevolodX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is code duplicate - needs to be handled at the lattice level or through self.create