Refactoring and Improving Price related API Route #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/components/client/StatsPage.tsx
Outdated
| @@ -164,7 +168,7 @@ const StatsPage = () => { | |||
| > | |||
| {isFailedToFetchData | |||
There was a problem hiding this comment.
Maybe we rename showData to a component that accepts <StatInfo ...{props} /> then we use composition api to render the outcome.
src/utils/cache.ts
Outdated
| res: NextApiResponse, | ||
| cacheHeader = `public, s-maxage=${config.CACHE_DURATION_SECONDS}, stale-while-revalidate=${config.CACHE_STALE_WHILE_REVALIDATE_SECONDS}`, | ||
| ) => { | ||
| res.setHeader('Cache-Control', cacheHeader) |
There was a problem hiding this comment.
Suggested change
| res.setHeader('Cache-Control', cacheHeader) | |
| import config from '@/config' | |
| import { NextApiResponse } from 'next' | |
| export const setCacheHeaders = ( | |
| res: NextApiResponse, | |
| cacheHeader = `public, s-maxage=${config.CACHE_DURATION_SECONDS}, stale-while-revalidate=${config.CACHE_STALE_WHILE_REVALIDATE_SECONDS}` | |
| ): void => { | |
| const headers = [ | |
| ['Cache-Control', cacheHeader], | |
| ['CDN-Cache-Control', cacheHeader], | |
| ['Vercel-CDN-Cache-Control', cacheHeader] | |
| ] as const | |
| headers.forEach(([name, value]) => res.setHeader(name, value)) | |
| } | |
src/components/client/StatsPage.tsx
Outdated
| <span>Loading...</span> | ||
| </Spinner> | ||
| ) | ||
| const ShowData = ({ |
There was a problem hiding this comment.
Let's rename this to
const NumericDisplay = ({
value,
prefix,
isFetched,
isFailedToFetchData
}: NumericDisplayProps) => {
// ... same implementation
}Also, we could handle the isFailedToFetchData inside it not outside, i.e
interface NumericDisplayProps {
value: number | undefined
prefix?: string
isFetched?: boolean
isFailedToFetchData?: boolean
}
const NumericDisplay = ({
value,
prefix,
isFetched,
isFailedToFetchData
}: ShowDataProps) => {
if (isFailedToFetchData) {
return '-'
}
if (value === undefined && !isFetched) {
return (
<Spinner variant="primary" role="status" size="sm">
<span>Loading...</span>
</Spinner>
)
}
return value ? (prefix || '') + Humanize.formatNumber(value) : '-'
}
|
Code Climate has analyzed commit 6f7383d and detected 0 issues on this pull request. View more on Code Climate. |
| useRadio(radioProps) | ||
| return ( | ||
| <chakra.label | ||
| {...htmlProps} | ||
| cursor={state.isDisabled ? 'not-allowed' : 'pointer'} | ||
| > | ||
| <input {...getInputProps({})} hidden /> | ||
| <Box {...getCheckboxProps()}> | ||
| <Box {...getRadioProps()}> |
There was a problem hiding this comment.
Missed this, why radio props?
There was a problem hiding this comment.
getCheckboxProps is deprecated
Adebesin-Cell
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and Improving Price-related API Route
This PR works on improving the caching on price related API route to reduce load on server, Resolve issue with twitter following API continuous loading.
Linked issues
closes EveripediaNetwork/issues#3728