-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IQ balance not showing in stake page #258
Conversation
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Code Climate has analyzed commit b0fcadb and detected 0 issues on this pull request. View more on Code Climate. |
I guess lets ensure we dont migrate important things like blockchain library without testing. I can see a million of cases needed to test for such important change. I assume nothing related to staking has been tested since the basic balance wasnt showing, so checkpoint increase amount increase time withdraw and claim hasnt being tested neither after migrating the library. cc: @Softdev1 this is the kind of things I pointed out earlier. This got merged 2h before the call. Same issue that landing page, site broken. |
In hindsight I think it should have been 2 separate PRs. The previous PR can be reverted and only the claim check can be implemented, wagmi upgrade can be in another PR which we can test more. |
Proper testing would be done |
noted sir, will correct this going forward |
this PR has conflicts |
this PR has conflicts |
awesome 👍🏻 |
Fix IQ balance not showing in stake page
useBalance
for non-native tokensLinked issues
closes EveripediaNetwork/issues#2608