Exchange integration #247
Merged
Exchange integration #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for the mobile screen, the stroke separating the icons is missing, also the right padding is not looking the same with the rest in other frame. left and right padding in each frame should be 12px
|
see the design on Figma
|
Simplypheyie96
requested changes
Apr 8, 2024
SidharthK2
reviewed
Apr 8, 2024
src/hooks/useErc20.ts
Outdated
| const { data: erc20Balance, refetch: refetchErc20Balance } = useBalance({ | ||
| address: address, | ||
| token: config.iqAddress as `0x${string}`, | ||
| enabled: shouldFetchBalance, |
There was a problem hiding this comment.
enabled is already set to false on undefined address
There was a problem hiding this comment.
Enabled prop is to prevent the hook from continuously running when the address is undefined. If it is not specified the hook will run continuously and throw error when the address is undefined
|
Code Climate has analyzed commit 750ffaf and detected 0 issues on this pull request. View more on Code Climate. |
Simplypheyie96
approved these changes
Apr 8, 2024
Dewalz
approved these changes
Apr 8, 2024
SidharthK2
approved these changes
Apr 9, 2024
Softdev1
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exchange Integration
This PR works on integrating exchange UI in the dashboard
Linked issues
closes EveripediaNetwork/issues#2462