Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/mlpc #16

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

add/mlpc #16

wants to merge 26 commits into from

Conversation

karpathy
Copy link
Contributor

still really bad.

  • use const properly
  • use int <-> size_t properly
  • the naming conventions for our "kernels" are totally messed up and inconsitent. e.g. variables a,b,c should have grads da, db, dc in the correct naming convention.
  • use model->inputs/targets properly, the way they are toggled atm is not good. the dataloader should be an independent, self-contained module and shouldn't "reach into" the model
  • in general, all classes should be closed/indepedent and re-usable, and we shouldn't be reaching into their attributes and toggling them around from the outside.
  • add omp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants