Implement From<&str> and From<&[u8]> for CryptoVec #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to some simple tests for this, but wasn't sure why the test module was platform gated. Pinging @irvingoujAtDevolution for some insight on the rationale. |
|
If I recall correctly, it was not there when I first created the test. |
|
You can safely remove it in this case, at least for these two for now. |
|
LGTM, thanks! @all-contributors add @joshka for code |
|
I've put up a pull request to add @joshka! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that
session.data(channel, "foo".into())works.