Fix symlink handling during theme lookup #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikReider
requested changes
Feb 10, 2024
| @@ -319,13 +319,23 @@ namespace SwaySettings { | |||
| if (min_ver % 2 != 0) min_ver++; | |||
|
|
|||
| foreach (string path in paths) { | |||
| while(FileUtils.test(path, FileTest.IS_SYMLINK)) { | |||
There was a problem hiding this comment.
Shouldn't these while loops be if statements?
|
Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
On NixOS when themes are installed, they are not stored inside real directories but are symlinked.
I noticed that when using swaysettings, it was unable to find the currently installed themes because the symlinks were not followed.
I made this patch which solves the issue. I am not an expert of glib nor vala so you may want to handle this in another way, do not hesitate to comment and tell me what to modify ;)