Prepare Hessian for f_opt too
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2024
Closed
|
Good catch, thanks! |
|
Just a heads up: this doesn't seem to have made it's way to a proper "release" yet (currently running into the same issue because I can only install 0.3.4 😕 ) |
|
Actually it has been released, but the general registry is currently lagging (see the conversation on Slack's helpdesk) so you only have access to slightly older versions |
|
Aaah gotcha; cheers:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Merge #37 first
At the moment, the Hessian is prepared for
fin theMarginalLogDensityconstructorMarginalLogDensities.jl/src/MarginalLogDensities.jl
Line 213 in aa1e957
but computed for
f_optinmodal_hessian!MarginalLogDensities.jl/src/MarginalLogDensities.jl
Line 288 in aa1e957
This is not allowed by the DifferentiationInterface API, you must prepare with the exact same function you plan to use later. This PR fixes the discrepancy and removes the DI compat upper bound.