Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extras): Added support for ghostty #395

Closed
wants to merge 2 commits into from

Conversation

ethanholz
Copy link
Contributor

Adds support for @mitchellh's Ghostty terminal emulator.

@EdenEast
Copy link
Owner

EdenEast commented Jan 3, 2024

Since the ghosttly terminal is still close source and not released I cannot confirm that these are correct. Do you have access to the beta and can confirm that these are correct?

@EdenEast EdenEast added enhancement New feature or request extras Relates to extra template generation labels Jan 3, 2024
@ethanholz
Copy link
Contributor Author

I do have access to the beta and I can confirm that these themes work. Prior to this, I modified the kitty terafox theme (you can find it here: https://github.com/ethanholz/nix-config/blob/main/ghostty/config) and previously carbonfox to work with these.

@mitchellh
Copy link

@EdenEast If you're interested, I'd be happy to add you to the beta. Anyone who maintains anything in an ecosystem around terminal emulators (themes included) is an instant invite. No pressure, just wanted to offer. Join the discord and ping me and I'll add you: https://discord.gg/ghostty

@EdenEast
Copy link
Owner

EdenEast commented Jan 4, 2024

Thanks for contributing. I looked at the extra generation and did some refactors, as I have not touched it in a while. I tried your Pr in ghostty and tested the changes. I will rebase your pr on the refactor that I did and merge this. Thanks for contributing and thanks @mitchellh for letting me try ghostty. Using it as my full time terminal with no issues. Feel the difference between my old terminal wezterm.

@ethanholz
Copy link
Contributor Author

Excellent! I appreciate you taking the time to test this, thanks to @mitchellh for providing access to the beta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extras Relates to extra template generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants