allow for mappings to structs in BackupDataRetriever #345
Conversation
…ds for mapping to structs
…with multiple mapping keys
…ing included in transaction
There was a problem hiding this comment.
I see there are two consecutive if statements. Could you explain why this separation is necessary instead of combining them into a single if with multiple conditions?
There was a problem hiding this comment.
Previously the if statement was inside else because we didn't have both structs and mappings at the same time. Now we are supporting mappings to structs and so we want to increment varName by s even if mappingKey is true.
There was a problem hiding this comment.
Thanks for the clarification
There was a problem hiding this comment.
Does the new code properly handle the state variable indices and structure properties without causing any issues or inconsistencies in the logic ?
There was a problem hiding this comment.
Yes as far as I'm aware, can you see any problems?
There was a problem hiding this comment.
I’ll go ahead and approve it
|
🎉 This PR is included in version 1.5.28 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.