Skip to content

Commit

Permalink
fix zeromorph with IPA accumulation
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael-EY committed Nov 29, 2024
1 parent 44e8a7b commit f9df361
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion plonkish_backend/src/accumulation/protostar/hyperplonk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -646,5 +646,5 @@ pub(crate) mod test {
tests!(gemini_kzg, Gemini<UnivariateKzg<Bn256>>);
tests!(zeromorph_kzg, Zeromorph<UnivariateKzg<Bn256>>);
tests!(gemini_ipa, Gemini<UnivariateIpa<grumpkin::G1Affine>>);
//tests!(zeromorph_ipa, Zeromorph<UnivariateIpa<grumpkin::G1Affine>>);
tests!(zeromorph_ipa, Zeromorph<UnivariateIpa<grumpkin::G1Affine>>);
}
2 changes: 1 addition & 1 deletion plonkish_backend/src/accumulation/sangria/hyperplonk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,5 @@ pub(crate) mod test {
tests!(gemini_kzg, Gemini<UnivariateKzg<Bn256>>);
tests!(zeromorph_kzg, Zeromorph<UnivariateKzg<Bn256>>);
tests!(gemini_ipa, Gemini<UnivariateIpa<grumpkin::G1Affine>>);
//tests!(zeromorph_ipa, Zeromorph<UnivariateIpa<grumpkin::G1Affine>>);
tests!(zeromorph_ipa, Zeromorph<UnivariateIpa<grumpkin::G1Affine>>);
}
6 changes: 4 additions & 2 deletions plonkish_backend/src/pcs/multilinear/zeromorph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,11 @@ where
let got = poly.evals().len() - 1;
return Err(err_too_large_deree("commit", pp.degree(), got));
}
let uni_poly = UnivariatePolynomial::monomial(poly.evals().to_vec());

UnivariateIpa::commit(pp, &uni_poly)
let bases = pp.monomial();
Ok(UnivariateIpaCommitment(
variable_base_msm(poly.evals(), &bases[..poly.evals().len()]).into(),
))
}

fn batch_commit<'a>(
Expand Down

0 comments on commit f9df361

Please sign in to comment.