Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing dependencies in setup.py and resolve indentation error #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing dependencies in setup.py and resolve indentation error #14

wants to merge 1 commit into from

Conversation

uceshaf
Copy link

@uceshaf uceshaf commented Jan 5, 2025

  • Added missing dependencies torchgeo and open_clip_torch to setup.py, which caused import errors.
  • Fixed an IndentationError in Major-TOM\src\embedder\models\SSL4EO_S2L1C.py caused by one less space.

mikonvergence
mikonvergence requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@mikonvergence mikonvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation error has been fixed in another earlier PR.

Can you remove it from PR and only keep the changes relating to the package requirements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikonvergence mikonvergence mikonvergence requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uceshaf @mikonvergence