Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numTotalResults
in the response summary is supposed to show the total number of results found by the query, regardless of pagination (see the spec).In some cases, the reference implementation will spuriously return pagination values instead of the total number of results. Here is an example:
numTotalResults
will be 31 using the example data provided.numTotalResults
will be 10 instead of 31, because build_response_summary() spuriously compares total results and paginationlimit
and returns whichever is smaller.The fix is to not overwrite numTotalResults with a different value. There were a number of cases and one function parameter that are no longer necessary.