Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test jaeger example and align examples with docs #134

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

pichlermarc
Copy link
Contributor

This PR

  • aligns the examples with our documentation by
    • using DT_ENDPOINT as the env var as opposed to DT_OTLP_ENDPOINT
    • using grpc as the default for the jaeger reciever instead of thrift_http
  • adds a test for the Jaeger example using the collector testbed
    • adds a dependency to github.com/open-telemetry/opentelemetry-collector-contrib/testbed/datasenders so that we can use the existing Jaeger gRPC data sender.

depends-on: #132 (removing examples that were meant for a different audience)

@pichlermarc pichlermarc requested a review from a team as a code owner February 22, 2024 12:25
@pichlermarc pichlermarc changed the title Test jaeger example and align examples with docs site Test jaeger example and align examples with docs Feb 22, 2024
@evan-bradley evan-bradley requested a review from dyladan February 22, 2024 13:56
@evan-bradley evan-bradley merged commit 03f88ae into main Feb 23, 2024
2 checks passed
@evan-bradley evan-bradley deleted the feat/add-jaeger-tests branch February 23, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants