Add e2e test for tail sampling config example #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
commented
Feb 8, 2024
evan-bradley
reviewed
Feb 8, 2024
joaopgrassi
commented
Feb 9, 2024
joaopgrassi
commented
Feb 9, 2024
evan-bradley
reviewed
Feb 9, 2024
evan-bradley
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After spending some time learning/looking at the testbed package in the collector, here's what I came up with to run e2e tests for our configuration samples:
New data Provider (
sampleConfigsDataProvider): This implements the DataProvider interface. Since we have samples with different expectation/results, the data provider simply receives a list of spans, and when the load generator asks for it, it returns that. This way, each test is in full control of the data that is sent to the collectorNew validator
(SampleConfigsValidator): This implements the TestCaseValidator interface, and the same way the data provider, receives the expected spans. It then compares the expected with the received from the mock back-end. For now the assertion simply looks for SpanIDs.Then it's just using the testbed framework to actually run the collector/tests. For now, I'm testing the tail sampling configuration.