Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CSI to fs from db #4292

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Migrate CSI to fs from db #4292

wants to merge 3 commits into from

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jan 15, 2025

Description

DAQ-4098

A rebase of epic/csi-nodb to main

  • didn't want to mess up the feature-branch, so did it in this branch
  • it's a single commit, to keep my sanity

Some minor changes that I introduced in the rebase:

  • the RetryTimeout is optional so we do not break during an upgrade
    • it is also not added to the OneAgent DaemonSet to not cause an redeploy due to it (the default should be fine here)
  • removed cgo steps from the CSI
  • made the CSI cleanup more consistent when it comes to error handling

How can this be tested?

CSI-driver should function without any issue.

@0sewa0 0sewa0 added the core Changes to core functionality of the Operator label Jan 15, 2025
@0sewa0 0sewa0 requested a review from a team as a code owner January 15, 2025 10:18
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 52.29717% with 488 lines in your changes missing coverage. Please review.

Project coverage is 64.05%. Comparing base (3b6085b) to head (bab8245).

Files with missing lines Patch % Lines
pkg/controllers/csi/driver/server.go 0.00% 71 Missing ⚠️
cmd/csi/provisioner/cmd.go 0.00% 68 Missing ⚠️
cmd/csi/server/cmd.go 0.00% 65 Missing ⚠️
pkg/controllers/csi/metadata/correctness.go 31.91% 61 Missing and 3 partials ⚠️
cmd/csi/init/cmd.go 0.00% 49 Missing ⚠️
...kg/controllers/csi/driver/volumes/app/publisher.go 66.10% 26 Missing and 14 partials ⚠️
pkg/controllers/csi/provisioner/cleanup/run.go 71.42% 23 Missing and 5 partials ⚠️
pkg/controllers/csi/provisioner/controller.go 52.94% 13 Missing and 3 partials ⚠️
...kg/controllers/csi/provisioner/cleanup/binaries.go 80.51% 11 Missing and 4 partials ⚠️
.../injection/codemodule/installer/symlink/symlink.go 55.55% 11 Missing and 1 partial ⚠️
... and 11 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4292      +/-   ##
==========================================
- Coverage   64.28%   64.05%   -0.24%     
==========================================
  Files         402      395       -7     
  Lines       26944    26125     -819     
==========================================
- Hits        17321    16734     -587     
+ Misses       8256     8090     -166     
+ Partials     1367     1301      -66     
Flag Coverage Δ
unittests 64.05% <52.29%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants