Remove command descriptions in case the whole application is failing

[gkrenn]

Description

Most of the operator subcommands are invoked by hardcoded pod commands. When these commands fail, a usage description is printed. This is unnecessary and causes confusion in the logs, so the print statements should be removed for subcommands that are not directly called by the user.

Example of confusing log:

{"level":"info","ts":"2024-10-09T13:16:50.592Z","logger":"injection-startup","msg":"CONTAINER_INFO environment variable is missing"}
Usage:
  dynatrace-operator init [flags]

Flags:
  -h, --help   help for init

Jira

How can this be tested?

Make the init container fail with an error, it should only log the error.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (67c2fad) to head (012156e).

Files with missing lines	Patch %	Lines
cmd/csi/init/builder.go	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4290   +/-   ##
=======================================
  Coverage   64.28%   64.28%           
=======================================
  Files         402      402           
  Lines       26944    26950    +6     
=======================================
+ Hits        17321    17326    +5     
- Misses       8256     8257    +1     
  Partials     1367     1367           

Flag	Coverage Δ
unittests	64.28% <83.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andriisoldatenko]

tested and it works as expected.

[andriisoldatenko]

Just quick note: toplevel command will still print --help in case of error (I think it's exepected and waht we want:

./cmd
{"level":"info","ts":"2025-01-14T20:01:53.192+0100","logger":"install-config","msg":"envvar not set, using default","envvar":"modules.json"}
{"level":"info","ts":"2025-01-14T20:01:53.192+0100","logger":"install-config","msg":"problem unmarshalling envvar content, using default","envvar":"modules.json","err":"unexpected end of JSON input"}
{"level":"info","ts":"2025-01-14T20:01:53.192+0100","logger":"install-config","msg":"envvar content read and set","envvar":"modules.json","value":""}
Error: operator binary must be called with one of the subcommands
Usage:
  dynatrace-operator [flags]
  dynatrace-operator [command]

Available Commands:
  completion      Generate the autocompletion script for the specified shell
  csi-init
  csi-provisioner
  csi-server
  help            Help about any command
  init
  operator
  startup-probe
  support-archive
  troubleshoot
  webhook-server

Flags:
  -h, --help   help for dynatrace-operator

Use "dynatrace-operator [command] --help" for more information about a command.

{"level":"info","ts":"2025-01-14T20:01:53.193+0100","logger":"main","msg":"operator binary must be called with one of the subcommands"}