Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiline support for variables, fix @markup implementation & update docs #65

Merged
merged 4 commits into from
May 6, 2015

Conversation

darcyclarke
Copy link
Member

Slowly getting this project up to snuff. Updated the parsing implementation so that it now supports multiline variables (#56). This also fixes multiple @markup variables (#54). Along with this change, I've gone ahead and refactored how we provide information/variables to the callback functions passed to dss.parser(). We give you interesting information like this.line.from and this.line.to which are line numbers associated with the contents of a variable (#53).

Documentation had not been touched in a long time, so I've now update it and will cut a new release once I'm happy that all of these changes aren't breaking anything they shouldn't be. The API has changed slightly (as noted above) so I'm a bit torn as to whether I should make this a major release or not (thoughts/opinions welcome).

I may write a custom parser to show how you can address #51, providing support for Jade, Markdown, HAML or whatever language for your @markup example.

darcyclarke added a commit that referenced this pull request May 6, 2015
Add multiline support for variables, fix @markup implementation & update docs
@darcyclarke darcyclarke merged commit 9971cfd into master May 6, 2015
@jeffjewiss
Copy link
Contributor

Do you want feedback on this kind of stuff? A little hard to discuss if the PRs are just merged 🚢 right away. 💥

@darcyclarke
Copy link
Member Author

@jeffjewiss going forward, yes. Just had to get this up-to-date and push through necessary work. I'm done playing god on master for this project 😉 That said, the other repos you saw pop up, they're fair game for the next few days. This repo (ie. the DSS parser) is the most important, so it makes sense that it is taken the most seriously.

@darcyclarke
Copy link
Member Author

It should also be noted that I haven't cut a new release, and won't until things are settled a bit. That means that anyone still referencing the project via npm isn't affected by my hazardous merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants