Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #198

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Improve tests #198

merged 3 commits into from
Nov 17, 2023

Conversation

timobrembeck
Copy link
Contributor

  • Use requests_mock for punycode domain tests
    (I also tried to replace the calls to https://badssl.com, however it's currently not possible since requests_mock cannot raise an exception based on the verify parameter we're using here)
  • Check status after message in tests (this makes it easier to debug failing tests)
  • Disable urllib warnings during test

@timobrembeck timobrembeck force-pushed the bugfix/tests-requests-mocker branch from be45c8e to 22b885a Compare November 17, 2023 11:06
claudep
claudep approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, as usual!

@claudep claudep merged commit c372147 into DjangoAdminHackers:master Nov 17, 2023
17 checks passed
@timobrembeck timobrembeck deleted the bugfix/tests-requests-mocker branch November 17, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timobrembeck @claudep