Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectBase: make INTERFACE_ID fully qualified #645

Closed
wants to merge 2 commits into from

Conversation

WangHoi
Copy link
Contributor

@WangHoi WangHoi commented Jan 3, 2025

Support implement Diligent's class interface in global or other namespaces.

For example:

/// Implementation of Diligent::IRenderStateCache
class CustomRenderStateCache final : public Diligent::ObjectBase<Diligent::IRenderStateCache>
{
public:
    using TBase = Diligent::ObjectBase<Diligent::IRenderStateCache>;

public:
    CustomRenderStateCache(Diligent::IReferenceCounters*               pRefCounters,
                         const Diligent::RenderStateCacheCreateInfo& CreateInfo);

    IMPLEMENT_QUERY_INTERFACE_IN_PLACE(Diligent::IID_RenderStateCache, TBase);
}

@WangHoi WangHoi closed this Jan 3, 2025
@WangHoi WangHoi deleted the pr-INTERFACE_ID branch January 3, 2025 07:54
{
char mb[4];
int n = wctomb(mb, WideStr[i]);
if (n > 0)

Check warning

Code scanning / PREfast

Buffer overrun while writing to 'mb'. Warning

Buffer overrun while writing to 'mb'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant